Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update overlay code to compile with iced master #201

Merged
merged 3 commits into from
Feb 6, 2024

Conversation

brianch
Copy link
Contributor

@brianch brianch commented Feb 2, 2024

Update to make things compile again after this iced change.

I'm unfamiliar with how to create widgets in iced, to be honest I changed things following a bit blindly iced's official widgets changes, so please be skeptical of this PR 😅 The widgets appear to be working correctly and the changes are almost all trivial, but I'm still not 100% sure if it doesn't introduce problems in the modal position for example.

@genusistimelord
Copy link
Collaborator

have you run all of the examples to ensure they all run?

also what was the model p[position issues? I already know they are not perfectly centered since the last changes atm just dont know how to go about getting the correct yet.

@brianch
Copy link
Contributor Author

brianch commented Feb 5, 2024

Yes, the examples work (the grid needs an additional change, the checkbox message is now set on the "on_toggle" function, and there's a panic related to glyphon while setting the horizontal alignment to center or right, but seems unrelated).

I mentioned the modal because the position isn't being explicitly set anymore, so I don't know if this will cause issues.

@genusistimelord
Copy link
Collaborator

could you fix the clippy and formating issue. I can then merge it and take over any needed changes to fix any issues.

@genusistimelord genusistimelord merged commit 1da1198 into iced-rs:main Feb 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants