changed number input's bounds to an inclusive range #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking about it and theres a lot of small changes I want aswell |
There was a problem hiding this comment.
I would like you to change this to use RangeBounds So it can use any of the Range types like
..
0..
0..100
..100
0..=100
I would also like you to add an additional trait requirement. https://docs.rs/num-traits/latest/num_traits/bounds/trait.Bounded.html
This will allow use to get a min and a max for all the Generics. Which for the .. style bounds we can then set the minimal and maximum numbers to the Unbounded.
genusistimelord
previously approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.