Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle Menu Bar on Click #257

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

sundaram123krishnan
Copy link
Contributor

@sundaram123krishnan sundaram123krishnan commented Jul 13, 2024

Requirement

In our pigg app, we encountered a scenario where it was necessary to close the menu bar when the user clicks on the menu bar itself.

2024-07-13 23-27-19

Implementation

To address this need, I implemented the feature to close the menu bar when clicked. When the menu bar is clicked, it toggles its open/close state.

Example:

2024-07-13 23-43-59

Any feedback is appreciated!

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is Fine as long as it does not interrupt drag and drop and so forth of inner widgets. Could you please verify the change works correctly with the drag color bars in the example?

@sundaram123krishnan
Copy link
Contributor Author

I just checked now, it definitely works fine

Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good then thank you.

@genusistimelord genusistimelord merged commit 752c573 into iced-rs:main Jul 14, 2024
2 checks passed
@sundaram123krishnan
Copy link
Contributor Author

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants