Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected issue in 'layout()' of 'FlushColumn' and 'FlushRow'. #265

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Corrected issue in 'layout()' of 'FlushColumn' and 'FlushRow'. #265

merged 1 commit into from
Jul 19, 2024

Conversation

rizzen-yazston
Copy link
Contributor

the copy and paste gremlin. fixed it. now Sidebar works as expected.

genusistimelord
genusistimelord reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@genusistimelord genusistimelord left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your Fix but you need to fix the clippy warnings before I will merge. Looks as if its not related so I will merge this

genusistimelord
genusistimelord approved these changes Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@genusistimelord genusistimelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your changes meet requirements despite the cargo update that broke selection list.

@genusistimelord genusistimelord merged commit 8a2a701 into iced-rs:main Jul 19, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genusistimelord genusistimelord genusistimelord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rizzen-yazston @genusistimelord