New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do NOT sort vocab lazily, because in a canister query you re-do it #7

Merged

icppWorld merged 1 commit into main from no-lazy-sort-vocab

Sep 3, 2023

Owner

icppWorld commented Sep 3, 2023 •

edited

Loading

Sort it once during canister initialization, which is an update call.

Doing it lazily during inference is not good, because that is a query call and it will be repeated each time.


          do NOT sort vocab lazily, because in a canister query you re-do it

359a54b

icppWorld merged commit c81c0f0 into main

1 check passed

icppWorld deleted the no-lazy-sort-vocab branch

September 3, 2023 14:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet