Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on pnpm i by sorting dev dependencies #459

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

EricPedley
Copy link
Member

@EricPedley EricPedley commented Nov 5, 2024

Summary

Error and fix, all in one screenshot:
image
The changes are from the autoformatter, I didn't touch anything manually. Is it normal for the pnpm lock to have 20k line diff for one line change in the package json? I can remove that diff from the PR if it isn't supposed to change that much.

Copy link
Collaborator

@dlustre dlustre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be fine I think. maybe the lockfile just wasn't up to date with the previous commit(s). it also tends to have a huge change set most of the time anyways

@EricPedley EricPedley merged commit 18ef554 into main Nov 5, 2024
1 check passed
@EricPedley EricPedley deleted the eric/fix-devdeps-sorting branch November 5, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants