Fixed function to create components node if missing #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you fix the typo on this line? |
|
And I believe the multi-line strings like the input in this docstring should be indented at least to the comma on the previous line (it was bothering me and might as well ask since you're already editing the file!): https://github.com/idaholab/FORCE/pull/16/files#diff-e5a05e2d7232d1a807b092ef316d5d19d9eaec4b6043a74cd4dd42512f90daa2R36 |
GabrielSoto-INL
requested changes
Jun 24, 2024
src/heron.py
Outdated
| heron_comp_list = [] # The list of components | ||
| for comp in component: | ||
| heron_comp_list.append(comp.attrib["name"]) # The list of components found in the HERON input XML file | ||
| # print(f" \n The following components are already in the HERON input XML file:'{heron_comp_list}'") |
There was a problem hiding this comment.
might be good to delete this commented line since it doesn't seem to serve a purpose anymore
GabrielSoto-INL
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#15
What are the significant changes in functionality due to this change request?
When a HERON XML script containing no
<Components>node is input to thesrc/heron/create_componentsets_in_HERON()function, the function now adds a new<Components>node. It also prints a message stating that the addition was made. This mirrors the function's behavior when dealing with input scripts that are missing<economics>or<CashFlow>nodes.For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.