Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TES Use cases used in HTGR-TES technoeconomic analysis are added. #26

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

JunyungKim
Copy link
Contributor


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#25

What are the significant changes in functionality due to this change request?

New use cases are added.
Point of Contact - So-bin Cho (sobin.cho@inl.gov)


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 3. Automated Tests should pass, including run_tests, pylint, and manual building tests.
  • 4. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 5. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a top-level readme for the case, to explain the following:

  • Who ran the case?
  • Who sponsored the case?
  • Who to contact about the analysis?
  • What was the purpose and methodology (brief description) for the analysis?
  • How is the data/runs structured?

Also a small request to define acronyms and explain the different models in the README in the ARMA folder. Otherwise, this looks great.

…ption sections to address the comments from Paul.
@PaulTalbot-INL PaulTalbot-INL merged commit ad56101 into idaholab:main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants