Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Technoeconomic HERON Use-case Upload #31

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

sobinc1
Copy link
Contributor

@sobinc1 sobinc1 commented Sep 11, 2024


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#30

What are the significant changes in functionality due to this change request?

microreactors-liquid-metal battery systems use-case added


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 3. Automated Tests should pass, including run_tests, pylint, and manual building tests.
  • 4. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 5. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

@PaulTalbot-INL PaulTalbot-INL linked an issue Sep 11, 2024 that may be closed by this pull request
10 tasks
@PaulTalbot-INL
Copy link
Collaborator

It looks like some tests are failing, but not due to your request. Let me look into it.

@sobinc1
Copy link
Contributor Author

sobinc1 commented Sep 16, 2024

Thanks for reviewing the request. Please let me know if you need any additional information or have any questions.

@PaulTalbot-INL
Copy link
Collaborator

Thank you! I'm working on figuring out why the tests aren't passing; it's not the fault of your PR. We should have it cleared up soon. Thank you for your patience. If there's any urgency to the merge, let me know!

@joshua-cogliati-inl
Copy link
Collaborator

Hm, it seems like this is still picking up the submodule ids from itself. It might be useful to do a git merge origin/main to pull in the latest changes in main.

LMB -paper publication

rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
rting with '#' will be ignored, and an empty message aborts
LMB
 be ignored, and an empty message aborts
@PaulTalbot-INL
Copy link
Collaborator

LGTM. Thank you for your patience.

@PaulTalbot-INL PaulTalbot-INL merged commit e555bc0 into idaholab:main Oct 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Technoeconomic HERON Use-case Upload
3 participants