Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unittest rook tester #35

Closed

Conversation

caleb-sitton-inl
Copy link
Collaborator


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#34

What are the significant changes in functionality due to this change request?

This contains a file defining a new tester that inherits from RavenPython and simplifies the use of the unittest module when running unit tests through rook. The unit tests in FORCE have been updated to use this new tester.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 3. Automated Tests should pass, including run_tests, pylint, and manual building tests.
  • 4. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 5. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

@PaulTalbot-INL
Copy link
Collaborator

Do you think this might be useful more broadly to RAVEN applications, by including it in the RAVEN base testers?

@caleb-sitton-inl
Copy link
Collaborator Author

@PaulTalbot-INL Yes, I think it could be. It doesn't look like the unittest module is currently being broadly used in unit tests for RAVEN, but adding this tester would facilitate its potential use in the future in unit tests both for RAVEN and its submodules.

@PaulTalbot-INL
Copy link
Collaborator

@wangcj05 Here is the unit tester to look at for consideration in RAVEN instead.

@wangcj05
Copy link

wangcj05 commented Sep 27, 2024 via email

@caleb-sitton-inl
Copy link
Collaborator Author

This PR has been moved to RAVEN. See https://github.com/idaholab/raven/pull/2382

@dylanjm dylanjm closed this Oct 9, 2024
@caleb-sitton-inl caleb-sitton-inl deleted the unittest-rook-tester branch October 10, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants