Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create easily installable packages of FORCE tools #37

Merged
merged 60 commits into from
Oct 17, 2024

Conversation

j-bryan
Copy link
Contributor

@j-bryan j-bryan commented Sep 30, 2024


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#36

What are the significant changes in functionality due to this change request?
  • Uses the cx_Freeze package to create executables of RAVEN, HERON, and TEAL main scripts with a self-contained Python environment.
  • Adds a simple launcher GUI to run RAVEN, HERON, and TEAL files without interacting with a command line.
  • Creates scripts to automate the creation of the frozen executables.
  • Scripts the creation of a macOS app bundle for FORCE tools with NEAMS Workbench.
  • Uses an Inno Setup script to create a Windows installer executable.
  • Automatically configures Workbench to be able to create *.heron files and run HERON workflows for both macOS and Windows installations.
  • Includes selected documentation and examples (from RAVEN and HERON test directories) in the installer bundle.

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 3. Automated Tests should pass, including run_tests, pylint, and manual building tests.
  • 4. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test.
  • 5. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 6. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.

So instead we can manually run print_loc.py to get the file, and
then copy and past that into setup.py instead of using the import.
* Adds a basic GUI to run HERON and RAVEN
* Makes minor changes to package requirements for installation
* Handles ipopt files for building executable
* Fixes issue for netCDF4 import on Windows
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this and overall, it looks reasonable. I left a few comments. (I contributed to this pull so I can't approve by myself.)

package/ui/controllers/file_selection.py Outdated Show resolved Hide resolved
package/ui/utils.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran thru the README instructions on windows, and it generally worked. Thank you. I left some comments.

package/build_force.sh Outdated Show resolved Hide resolved
package/README.md Outdated Show resolved Hide resolved
package/README.md Outdated Show resolved Hide resolved
package/README.md Show resolved Hide resolved
Copy link
Collaborator

@joshua-cogliati-inl joshua-cogliati-inl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. No new comments.

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small update to documentation then should be ready to merge.

package/README.md Show resolved Hide resolved
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good to merge. Thanks!

@dylanjm dylanjm merged commit 6ef7bd9 into idaholab:main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants