Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tally segment parsing bug fix. #409

Merged
merged 8 commits into from
Jul 1, 2024
1 change: 1 addition & 0 deletions doc/source/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ MontePy Changelog
----------------------

**Bug fixes**
* Fixed bug with parsing tally segments (#377)

**CI/CD**
* Fixed project metadata for author to show up correctly on PyPI (#408)
Expand Down
2 changes: 2 additions & 0 deletions montepy/data_inputs/data_parser.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
material,
mode,
tally,
tally_segment,
tally_multiplier,
thermal_scattering,
universe_input,
Expand All @@ -23,6 +24,7 @@
mode.Mode,
tally.Tally,
tally_multiplier.TallyMultiplier,
tally_segment.TallySegment,
thermal_scattering.ThermalScatteringLaw,
transform.Transform,
volume.Volume,
Expand Down
22 changes: 22 additions & 0 deletions montepy/data_inputs/tally_segment.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# Copyright 2024, Battelle Energy Alliance, LLC All Rights Reserved.
import montepy
from montepy.data_inputs.data_input import DataInputAbstract
from montepy.input_parser.tally_parser import TallyParser


class TallySegment(DataInputAbstract):
""" """

_parser = TallyParser()
MicahGale marked this conversation as resolved.
Show resolved Hide resolved

@staticmethod
def _class_prefix():
return "fs"

@staticmethod
def _has_number():
return True

@staticmethod
def _has_classifier():
return 0
7 changes: 7 additions & 0 deletions tests/test_tally.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@


from unittest import TestCase
import pytest


class TestTallyParser(TestCase):
Expand Down Expand Up @@ -38,3 +39,9 @@ def test_parsing_tally_multiplier(self):
print(test)
input = Input([test], BlockType.DATA)
data = parse_data(input)


@pytest.mark.parametrize("line", ["fs14 -123", "fs12 -456 t"])
tjlaboss marked this conversation as resolved.
Show resolved Hide resolved
def test_tally_segment_init(line):
input = Input([line], BlockType.DATA)
data = parse_data(input)
Loading