Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the addition of a numbered object from another problem #467

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

tjlaboss
Copy link
Collaborator

@tjlaboss tjlaboss commented Aug 2, 2024

Description

Fix bug when with copying numbered objects from one MCNP_Problem to another when the new number in the new problem is already in use in the old problem.

Fixes #466

Checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog

@tjlaboss tjlaboss marked this pull request as draft August 2, 2024 19:21
@tjlaboss tjlaboss marked this pull request as ready for review August 2, 2024 19:32
@tjlaboss tjlaboss requested a review from MicahGale August 2, 2024 19:32
tests/test_numbered_collection.py Outdated Show resolved Hide resolved
@MicahGale
Copy link
Collaborator

#466 MWE needs to be complete prior to merge so we can actually make sure the test makes sense.

tests/test_numbered_collection.py Outdated Show resolved Hide resolved
@tjlaboss tjlaboss enabled auto-merge August 8, 2024 18:05
@tjlaboss tjlaboss merged commit 896ee12 into develop Aug 8, 2024
13 checks passed
@tjlaboss tjlaboss deleted the 466_append_renumber branch August 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

append_renumber() validates against old problem
2 participants