Enable Pickling of Tallies #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
the
bugs
Merged
|
Might fix this one day. |
|
I'm really hoping that #539 fixes most of the issues here. |
|
Ok didn't fix it. But at least now there isn't infinite recursion to deal with while debugging. |
|
progress |
|
I know you opened this PR @tjlaboss, but want to review it since I did all the fixes here? |
|
Approved. |
MicahGale
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR first demonstrated failures for inputs involving tallies. It has since been expanded to resolve #463.
Update from @MicahGale, and fixes:
This bug is related to
slyYaccdescended objects. Basically they can end up in states where they cannot be pickled. The first issue is that sometimes they keepparser.tokensas a generator. The other is that they will store aparser.productionwhich has a lot oflambdafunctions, and closures. None of these are allowed for copying or pickling. To fix this I:parser.tokenswhen complete._parserfrom being pickled as it isn't needed.Fixes #463.
checklist