Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with shortcut recompression #520

Merged
merged 75 commits into from
Sep 11, 2024
Merged

Fix issue with shortcut recompression #520

merged 75 commits into from
Sep 11, 2024

Commits on Aug 28, 2024

  1. Implemented reading input from a stream.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    9ab65f6 View commit details
    Browse the repository at this point in the history

  2. Test read/write all input files.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    97683b9 View commit details
    Browse the repository at this point in the history

  3. Made verification tests harder.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c5534ae View commit details
    Browse the repository at this point in the history

  4. Replicated #499 by forcing a recompression.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c260d75 View commit details
    Browse the repository at this point in the history

  5. Dumped whole file to stdout.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    94233d4 View commit details
    Browse the repository at this point in the history

  6. Expand tabs and update test to new inputs.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    e377297 View commit details
    Browse the repository at this point in the history

  7. tried to use interpolation for test.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    37cf930 View commit details
    Browse the repository at this point in the history

  8. Actually replicated #499 with multiple shortcuts in a line.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    0eab3c9 View commit details
    Browse the repository at this point in the history

  9. Updated test again with new importance gold.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    2f92864 View commit details
    Browse the repository at this point in the history

  10. Fixed logic to detect when you can smash repeats together.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c577a88 View commit details
    Browse the repository at this point in the history

  11. Updated logic to test for matching value with valueNode.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c4b56ac View commit details
    Browse the repository at this point in the history

  12. Undid debugging.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4f71d4a View commit details
    Browse the repository at this point in the history

  13. Updated logic to always check for edge node matching.

    @MicahGale
    MicahGale committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    4284c03 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2024

  1. Updated tests to cover more edge cases.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    4c7265e View commit details
    Browse the repository at this point in the history

  2. Made logic clearer and more pythonic.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1529886 View commit details
    Browse the repository at this point in the history

  3. Removed implicit importance to avoid parrot out bug.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5e0f8ab View commit details
    Browse the repository at this point in the history

  4. Fixed bug in validate for cylinder_on_axis.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    2d3aa54 View commit details
    Browse the repository at this point in the history

  5. Made it possible to have integer interpolations.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    8ff6b69 View commit details
    Browse the repository at this point in the history

  6. Started framework for geometry tree recompressing interpolations.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    73800b8 View commit details
    Browse the repository at this point in the history

  7. Switched to preserving shortcut type for geometry stuff.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    b8b8b3b View commit details
    Browse the repository at this point in the history

  8. Exposed shortcut type.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0582457 View commit details
    Browse the repository at this point in the history

  9. Made system to make a shortcutNode from scratch kind of.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dd16501 View commit details
    Browse the repository at this point in the history

  10. Formatted shortcuts inside of GeometryTree

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    e9d2e4e View commit details
    Browse the repository at this point in the history

  11. Updated tests to avoid complex reads and implicit importances.

    @MicahGale
    MicahGale committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    5d17fd1 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. Replicated #352.

    @MicahGale
    MicahGale committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    ba4ce30 View commit details
    Browse the repository at this point in the history

  2. Fixed test to expect three leading comments.

    @MicahGale
    MicahGale committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    0f79257 View commit details
    Browse the repository at this point in the history

  3. Made system to ignore default parameters for trailing comments.

    @MicahGale
    MicahGale committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    fabfb52 View commit details
    Browse the repository at this point in the history

  4. Avoid cross-block trailing comment transfer.

    @MicahGale
    MicahGale committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    f033d97 View commit details
    Browse the repository at this point in the history

  5. Updated delete trailing comment to match new get_trailing_comment.

    @MicahGale
    MicahGale committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    3edca07 View commit details
    Browse the repository at this point in the history

  6. Skip empty nodes in the tail.

    @MicahGale
    MicahGale committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    08a0c98 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2024

  1. Updated test to be more thurough)

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    bd3e31f View commit details
    Browse the repository at this point in the history

  2. Updated ClassifierNode handling of padding for trailing and str.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    081d4db View commit details
    Browse the repository at this point in the history

  3. Updated get trailing comment logic to handle valueNodes in tree.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    5029946 View commit details
    Browse the repository at this point in the history

  4. Updated complex logic for deleteing trailing comments.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    f87c875 View commit details
    Browse the repository at this point in the history

  5. Updated geometry expansion tests to be more exhaustive.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    ee08583 View commit details
    Browse the repository at this point in the history

  6. Fixed test to be looser.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    aa06f22 View commit details
    Browse the repository at this point in the history

  7. fixed bugs in M in geometry.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    3f7f277 View commit details
    Browse the repository at this point in the history

  8. Added more edge cases.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    a00afe4 View commit details
    Browse the repository at this point in the history

  9. Started debugging.

    @MicahGale
    MicahGale committed Aug 31, 2024
    Configuration menu
    Copy the full SHA
    ab65de6 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Made system for tracking left and right shortuts

    @MicahGale
    MicahGale committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    97bca51 View commit details
    Browse the repository at this point in the history

  2. Updated shortcut finding logic to find shortcuts in the middle.

    @MicahGale
    MicahGale committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    24ca152 View commit details
    Browse the repository at this point in the history

  3. Close enough with padding.

    @MicahGale
    MicahGale committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    a9517e8 View commit details
    Browse the repository at this point in the history

  4. Updated changelog with #520 PR.

    @MicahGale
    MicahGale committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    aca2f85 View commit details
    Browse the repository at this point in the history

  5. Avoided marking shortcuts overriding old shortcut.

    @MicahGale
    MicahGale committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    59058d0 View commit details
    Browse the repository at this point in the history

  6. Fixed over-appending leaves to the new list.

    @MicahGale
    MicahGale committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    b6ec5d4 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Added tests for mark_last_leaf_shortcut.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    b42f4a8 View commit details
    Browse the repository at this point in the history

  2. Started testing for flatten_shortcut.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    847d2d2 View commit details
    Browse the repository at this point in the history

  3. Finished test for flatten_shortcuts.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    06a44cb View commit details
    Browse the repository at this point in the history

  4. Fixed test typos.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    bfa81a8 View commit details
    Browse the repository at this point in the history

  5. Fixed tests because I can't count at all.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    0e15135 View commit details
    Browse the repository at this point in the history

  6. Fixed bug with excess depth in call.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f7d140d View commit details
    Browse the repository at this point in the history

  7. Cleaned up with @tjlaboss feedback.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    058b757 View commit details
    Browse the repository at this point in the history

  8. Added test replicate new edge case from @tjlaboss.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    f7ff8ba View commit details
    Browse the repository at this point in the history

  9. Added more exhaustive shortcut tests.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9483f89 View commit details
    Browse the repository at this point in the history

  10. Expanded using last node on formatting to all shortcuts, and handled … 

    …interpolate messiness.
    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    6b6cdcb View commit details
    Browse the repository at this point in the history

  11. Fixed test to be all caps.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    82d7c9e View commit details
    Browse the repository at this point in the history

  12. Updated logic for multiply shortcuts using neigbors.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    9430561 View commit details
    Browse the repository at this point in the history

  13. Created system to track starting value for interpolate in geometry tr… 

    …ees.
    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    5a8b34a View commit details
    Browse the repository at this point in the history

  14. Added doc strings for new functions.

    @MicahGale
    MicahGale committed Sep 3, 2024
    Configuration menu
    Copy the full SHA
    628cd9d View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Merge branch 'develop' into 499-shortcuts-recompressed-incorrectly

    @MicahGale
    MicahGale authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0848559 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into 499-shortcuts-recompressed-incorrectly

    @tjlaboss
    tjlaboss authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    843db18 View commit details
    Browse the repository at this point in the history

  3. Triggered edge case from #526 #520

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    c43e8cf View commit details
    Browse the repository at this point in the history

  4. Update gold value with new line.

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    128c651 View commit details
    Browse the repository at this point in the history

  5. Tried to move the trailing comments around the special tree for now.

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    bfdb083 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into 499-shortcuts-recompressed-incorrectly

    @MicahGale
    MicahGale authored Sep 10, 2024
    Configuration menu
    Copy the full SHA
    92f52e4 View commit details
    Browse the repository at this point in the history

  7. Updated test with new input model.

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9a88b22 View commit details
    Browse the repository at this point in the history

  8. Fixed potential repr bug.

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    9acdc7f View commit details
    Browse the repository at this point in the history

  9. Tried to figure out where this stupid valuenode comment is coming from.

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    39a12c4 View commit details
    Browse the repository at this point in the history

  10. Made test more robust.

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    35ffa26 View commit details
    Browse the repository at this point in the history

  11. Found where the syntax node actually lives; needs work.

    @MicahGale
    MicahGale committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ff6b81f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Removed forsed failure.

    @MicahGale
    MicahGale committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b8b1a2c View commit details
    Browse the repository at this point in the history

  2. Setup system to track which particles were paired up.

    @MicahGale
    MicahGale committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    9da343a View commit details
    Browse the repository at this point in the history

  3. Updated to use actual trees, and ensured all affected trees cleared.

    @MicahGale
    MicahGale committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5882881 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into 499-shortcuts-recompressed-incorrectly

    @MicahGale
    MicahGale authored Sep 11, 2024
    Configuration menu
    Copy the full SHA
    1b559bc View commit details
    Browse the repository at this point in the history

  5. Fixed bug where the parameters weren't actually loaded into syntax tree.

    @MicahGale
    MicahGale committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a30549b View commit details
    Browse the repository at this point in the history