Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libraries #14

Closed
wants to merge 2 commits into from
Closed

Add libraries #14

wants to merge 2 commits into from

Conversation

wangcj05
Copy link
Collaborator

@wangcj05 wangcj05 commented Apr 5, 2021

Add Spacy and NLTK for nature language processing capabilities, close #13

@wangcj05 wangcj05 changed the base branch from master to devel April 5, 2021 19:41
@wangcj05 wangcj05 requested a review from mandd April 5, 2021 19:57
Copy link
Collaborator

@mandd mandd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update also the dependency list?

@wangcj05
Copy link
Collaborator Author

wangcj05 commented Apr 5, 2021

Currently, we do not have a module use these two libraries yet. I would suggest to update our documents when we start to create a module that use these libraries.

@mandd
Copy link
Collaborator

mandd commented Apr 5, 2021

Currently, we do not have a module use these two libraries yet. I would suggest to update our documents when we start to create a module that use these libraries.

This is why I could not find such document. Let's put this task in our todo list.

mandd
mandd previously approved these changes Apr 5, 2021
@wangcj05
Copy link
Collaborator Author

wangcj05 commented Apr 5, 2021

I have opened an issue #15

@moosebuild
Copy link

Job Test linux pull on b6ad3d7 : invalidated by @mandd

@moosebuild
Copy link

Job Test linux pull on 451870e : invalidated by @wangcj05

@moosebuild
Copy link

Job Test linux pull on 451870e : invalidated by @wangcj05

test with new development

@wangcj05
Copy link
Collaborator Author

This PR can be closed.

@wangcj05 wangcj05 closed this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add dependencies
3 participants