Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit instantiation for complex RankFourTensor operation #15735

Closed
wants to merge 1 commit into from
Closed

Add explicit instantiation for complex RankFourTensor operation #15735

wants to merge 1 commit into from

Conversation

recuero
Copy link
Contributor

@recuero recuero commented Aug 7, 2020

Closes #15734

@moosebuild
Copy link
Contributor

Job Precheck on e93df2b : invalidated by @loganharbour

@moosebuild
Copy link
Contributor

Job Precheck on e93df2b wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/15735/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 993719694528eec103be499d263e274696ff58d9

@moosebuild
Copy link
Contributor

Job Precheck on e93df2b : canceled by @loganharbour

@moosebuild
Copy link
Contributor

Job Precheck on e93df2b : canceled by @recuero

@recuero recuero force-pushed the RankFourTensorOperation branch 3 times, most recently from e348b62 to 83aa2c7 Compare August 7, 2020 18:24
dschwen
dschwen reviewed Aug 7, 2020
View reviewed changes
framework/src/utils/RankFourTensor.C Outdated
@@ -12,6 +12,8 @@

template class RankFourTensorTempl<Real>;
template class RankFourTensorTempl<DualReal>;
template class RankTwoTensorTempl<Complex>;
template class RankFourTensorTempl<Complex>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Complex typedef is not known in MOOSE. This instantiation should be in Magpie for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In ComplexTypes.C to be precise

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't Complex be available in MOOSE through libmesh: libmesh_common.h?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, if libmesh was compiled with complex number support. But that's a bit besides the point. By design I'm trying to keep unnecessary explicit instantiations for complex types out of the main moose code base. Everything else related to complex types is in Magpie, so this belongs there, too. Maybe at some point in the future we'll have proper complex number support for the FEM parts of MOOSE and these instantiations will be useful in MOOSE, but I don't think thats the case quite yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if libmesh was compiled with complex number support.

I think that typedef is there all the time. I understood your point.

@recuero recuero closed this Aug 7, 2020
@recuero
Copy link
Contributor Author

recuero commented Aug 7, 2020

This can be done in Magpie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwen dschwen dschwen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add explicit instantiation for RankFourTensor complex operation
3 participants
@recuero @moosebuild @dschwen