-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit instantiation for complex RankFourTensor operation #15735
Conversation
e93df2b
to
56e6406
Compare
Job Precheck on e93df2b : invalidated by @loganharbour |
Job Precheck on e93df2b wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
Job Precheck on e93df2b : canceled by @loganharbour |
e348b62
to
83aa2c7
Compare
framework/src/utils/RankFourTensor.C
Outdated
@@ -12,6 +12,8 @@ | |||
|
|||
template class RankFourTensorTempl<Real>; | |||
template class RankFourTensorTempl<DualReal>; | |||
template class RankTwoTensorTempl<Complex>; | |||
template class RankFourTensorTempl<Complex>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Complex
typedef is not known in MOOSE. This instantiation should be in Magpie for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In ComplexTypes.C
to be precise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't Complex
be available in MOOSE through libmesh: libmesh_common.h
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, if libmesh was compiled with complex number support. But that's a bit besides the point. By design I'm trying to keep unnecessary explicit instantiations for complex types out of the main moose code base. Everything else related to complex types is in Magpie, so this belongs there, too. Maybe at some point in the future we'll have proper complex number support for the FEM parts of MOOSE and these instantiations will be useful in MOOSE, but I don't think thats the case quite yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if libmesh was compiled with complex number support.
I think that typedef is there all the time. I understood your point.
83aa2c7
to
d920603
Compare
This can be done in Magpie |
Closes #15734