Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nonlocal cracktip material #29576

Open
wants to merge 14 commits into
base: next
Choose a base branch
from
Open

Nonlocal cracktip material #29576

wants to merge 14 commits into from

Conversation

lynnmunday
Copy link
Contributor

closes #29575

@moosebuild
Copy link
Contributor

moosebuild commented Dec 19, 2024 •
edited
Loading

Job Documentation, step Docs: sync website on ad6bdcc wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Conda (Rocky) on 3740102 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job OpenMPI on 3740102 : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job Test HPC on 3740102 : invalidated by @lynnmunday

@lynnmunday
Copy link
Contributor Author

@bwspenc Will you review?

@moosebuild
Copy link
Contributor

moosebuild commented Dec 20, 2024 •
edited
Loading

Job Coverage, step Generate coverage on ad6bdcc wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Solid mechanics

2974c5 #29576 ad6bdc
Total Total +/- New
Rate 84.95% 84.96% +0.01% 91.84%
Hits 28318 28341 +23 90
Misses 5015 5017 +2 8

Diff coverage report

Full coverage report

Xfem

2974c5 #29576 ad6bdc
Total Total +/- New
Rate 82.38% 82.37% -0.01% 91.18%
Hits 6907 6916 +9 31
Misses 1477 1480 +3 3

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@lynnmunday lynnmunday marked this pull request as draft December 20, 2024 16:41
@lynnmunday lynnmunday marked this pull request as ready for review December 20, 2024 21:28
@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch 2 times, most recently from 8da5e53 to 81f8043 Compare December 20, 2024 22:51
@lynnmunday
Fixing MeshCut2DFractureUserObject to use just stress based or consta…
22a9519 
…nt Kcrit or kcrit from vpp crack growth. Added error checking and testing for these options.
@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch from 81f8043 to 22a9519 Compare December 23, 2024 17:18
@moosebuild
Copy link
Contributor

All jobs on 22a9519 : invalidated by @lynnmunday

bwspenc
bwspenc requested changes Dec 23, 2024
View reviewed changes
modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalScalar.md Outdated
@@ -0,0 +1,19 @@
# CrackFrontNonlocalScalar
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like CrackFrontNonlocalScalarMaterial would be more descriptive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalScalar.md Outdated

## Description

This object computes the average scalar material property at the crack front points defined by [CrackFrontDefinition.md]. The main use case for this `VectorPostprocessor` is to compute an average fracture toughness or $k_crit$ at the crack front for use with the `MeshCut2DFractureUserObject` to grow cracks. This allows for spatially varying $k_crit$ values defined by a `Material`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This object computes the average scalar material property at the crack front points defined by [CrackFrontDefinition.md]. The main use case for this `VectorPostprocessor` is to compute an average fracture toughness or $k_crit$ at the crack front for use with the `MeshCut2DFractureUserObject` to grow cracks. This allows for spatially varying $k_crit$ values defined by a `Material`.
This object computes the average of a scalar material property over regions ahead of the crack tip, as defined by the front points obtained from [CrackFrontDefinition.md]. The main use cases for this `VectorPostprocessor` is to compute an average fracture toughness or $k_crit$ at the crack front for use with the `MeshCut2DFractureUserObject` to grow cracks, but this can be used for other scalar material properties as well. This allows for spatially varying $k_crit$ values defined by a `Material`.

modules/solid_mechanics/doc/content/source/vectorpostprocessors/CrackFrontNonlocalStress.md Outdated Show resolved Hide resolved
modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalMaterialBase.h Outdated Show resolved Hide resolved
modules/solid_mechanics/include/vectorpostprocessors/CrackFrontNonlocalStress.h Outdated Show resolved Hide resolved
modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C Outdated Show resolved Hide resolved
modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalMaterialBase.C Outdated Show resolved Hide resolved
modules/solid_mechanics/src/vectorpostprocessors/CrackFrontNonlocalStress.C Outdated
void
CrackFrontNonlocalStress::execute()
: CrackFrontNonlocalMaterialBase(parameters),
_stress(getMaterialProperty<RankTwoTensor>(_base_name + getParam<std::string>("material_name")))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is specifically operating on stress, I prefer the original parameter ('stress') to 'material_name'. That would require moving the parameter from the base class into the derived classes, but I think that's worth doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dschwen helped me move this to the derived classes.

modules/xfem/src/userobjects/MeshCut2DFractureUserObject.C Outdated Show resolved Hide resolved
modules/xfem/test/tests/mesh_cut_2D_fracture/edge_crack_2d_propagation.i Outdated Show resolved Hide resolved
lynnmunday and others added 2 commits December 23, 2024 12:53
@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch from ed48de3 to 91b45b9 Compare December 23, 2024 21:42
@moosebuild
Copy link
Contributor

Job Precheck, step Clang format on 91b45b9 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/29576/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 2974c54c5269c9b763547954236d33e3a55a8710

@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch 2 times, most recently from 1c83119 to 4b6d396 Compare December 23, 2024 22:01
@moosebuild
Copy link
Contributor

All jobs on 4b6d396 : invalidated by @lynnmunday

@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch 3 times, most recently from c7bdcd9 to 4512c85 Compare December 31, 2024 15:17
@lynnmunday lynnmunday force-pushed the nonlocal_cracktip_matl branch from 4512c85 to ad6bdcc Compare January 2, 2025 00:49
@moosebuild
Copy link
Contributor

Job OpenMPI on ad6bdcc : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job Test HPC on ad6bdcc : invalidated by @lynnmunday

2 similar comments
@moosebuild
Copy link
Contributor

Job Test HPC on ad6bdcc : invalidated by @lynnmunday

@moosebuild
Copy link
Contributor

Job Test HPC on ad6bdcc : invalidated by @lynnmunday

@lynnmunday
Copy link
Contributor Author

@bwspenc Will you review this again and merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwspenc bwspenc bwspenc requested changes

@jiangwen84 jiangwen84 Awaiting requested review from jiangwen84 jiangwen84 is a code owner

@dschwen dschwen Awaiting requested review from dschwen dschwen is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@bwspenc bwspenc

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a vector postprocessor that can sample the materials at a crack front
3 participants
@lynnmunday @moosebuild @bwspenc