Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add const generic numeric compact deserialization helpers #37

Merged
merged 2 commits into from
Jan 12, 2024
Merged

add const generic numeric compact deserialization helpers #37

merged 2 commits into from
Jan 12, 2024

Conversation

olekspickle
Copy link
Contributor

No description provided.

@iddm
Copy link
Owner

iddm commented Oct 9, 2023

Thank you for your contribution!

I have a few questions, though:

  1. Will you please provide implementations for all the other primitive types (if possible)?
  2. Will you please address the clippy lints and test issues?

@olekspickle
Copy link
Contributor Author

olekspickle commented Oct 9, 2023 •
edited
Loading

Clippy no problem, as for types - I added const generics available as of now in stable: meaning String and f32/f64 is not implemented yet

@iddm
Copy link
Owner

iddm commented Jan 12, 2024

Hi again, and thank you for the contribution! Sorry, I forgot to re-review it again after we last spoke.

@iddm iddm merged commit 6436d99 into iddm:master Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iddm iddm iddm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olekspickle @iddm