-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add common/platforms as git submodule #239
base: main
Are you sure you want to change the base?
Conversation
@Myrausman Thanks! Let's see if the CI passes. |
@Myrausman the CI is failing (though it is showing it as passed). These generators read config.mk files inside platforms directories. If you look at the check, we just clone this github repo. Can you share the command on how to checkout this module before running the flow please? |
@saicharan0112 , The follwoing command should help ensure that the submodule you mentioned is properly checked out before running the flow. |
Ok, but can you please add the module to this list https://github.com/idea-fasoc/OpenFASOC/blob/main/.gitmodules ? |
I did enter module to this list as you can check here: https://github.com/Myrausman/OpenFASOC/blob/issue-70/.gitmodules |
Perfect! |
@saicharan0112 ,I would appreciate it if you could provide some insights or updates regarding the current status of the pull request. Are there any additional changes or actions required from my end to move it forward? |
@Myrausman really appreciate your patience. This directory is used by all generators so I think its good to verify once with everybody what they think this change will effect the generators. However I don't think there are any changes from your side afais. Let me talk to others if that's ok with you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Myrausman : the platforms repository needs some restructuring, this PR will take care of it idea-fasoc/platforms#2. I updated workflows files to use the submodules after checkout of the repository.
Thanks for your contribution.
okay, thank you |
@alibillalhammoud @chetanyagoyal @nicholas this PR aims to add the platform folders as submodule which will reduce the repo size by a lot. Can you please check this? |
I am not to experienced with the github CI. I tried cloning the fork and running the following:
For some reason this only results in LICENSE and a .git file in platforms folder. I would expect the whole platforms to be copied in. Perhaps I am running this wrong? |
@@ -5,3 +5,6 @@ | |||
path = tapeouts | |||
url = https://github.com/idea-fasoc/openfasoc-tapeouts.git | |||
branch = main | |||
[submodule "openfasoc/common/platforms"] | |||
path = openfasoc/common/platforms | |||
url = https://github.com/idea-fasoc/platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The platforms
repo has a folder common/platforms
in it. Does this mean the submodule will initialize in common/platforms/common/platforms
? @Myrausman
@harshkhandeparkar The CI will fail after merging this? Have you thought this through? are the checks updated? |
idea-fasoc/platforms#2 This PR has to be merged first. The directory structure was wrong... |
@chetanyagoyal can you please check why this is failing or whether it is intended behaviour? |
will check |
In order to address issue #70
1.Removed old common/platforms folder
2.Added openfasoc-platforms repo as submodule in the common/platforms folder