Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified hardcoded PDK path with the environment variable PDK_ROOT in sky130_mapped.py #325

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iitkgpshubham
Copy link

@iitkgpshubham iitkgpshubham commented Jun 25, 2024

  • Modified hardcoded PDK path with the environment variable PDK_ROOT in sky130_mapped.py
  • PDK_ROOT also exist in docker installation, see Line 25 docker/conda/Dockerfile ENV PDK_ROOT=/usr/bin/miniconda3/share/pdk/
  • PDK_ROOT also created in Line 305 dependencies.sh export PDK_ROOT=/home/$(logname)/miniconda3/share/pdk/
  • PDK_ROOT variable is also used by other open source tools

@iitkgpshubham
Copy link
Author

@msaligane @chetanyagoyal The test are failing ImportError: numpy.core.multiarray failed to import.
I can see that tests uses numpy 2.0.0 Requirement already satisfied: numpy in /usr/bin/miniconda3/lib/python3.10/site-packages (from -r requirements.txt (line 3)) (2.0.0)

I use a version 1.26.4. I can see that docker also uses a same version. Please see if this can be used.

@chetanyagoyal
Copy link
Collaborator

@msaligane @chetanyagoyal The test are failing ImportError: numpy.core.multiarray failed to import. I can see that tests uses numpy 2.0.0 Requirement already satisfied: numpy in /usr/bin/miniconda3/lib/python3.10/site-packages (from -r requirements.txt (line 3)) (2.0.0)

I use a version 1.26.4. I can see that docker also uses a same version. Please see if this can be used.

We are handling this in a separate PR

pdk_root = Path('/usr/bin/miniconda3/share/pdk/')
pdk_root = Path('$PDK_ROOT')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has a lot of potential to fail. Please enclose all logic in a try and except block instead, where if the pdk_root can't be found, it defaults to the two possible locations (/usr/bin/... or /home/$(logname)/...)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if it makes sense now. However it is expected that PDK_ROOT variable gets created during installation...as docker installation does it.

@iitkgpshubham
Copy link
Author

@chetanyagoyal please see if the new changes makes sense. However it is expected that PDK_ROOT variable gets created during installation...as docker installation does it.

Copy link
Collaborator

@chetanyagoyal chetanyagoyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see if the workflows pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants