Skip to content

Commit

Permalink
update
Browse files Browse the repository at this point in the history
  • Loading branch information
mfilip committed Oct 31, 2023
1 parent 43609f7 commit 30684f6
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 63 deletions.
23 changes: 0 additions & 23 deletions .github/workflows/ci-73-m24.yml

This file was deleted.

23 changes: 0 additions & 23 deletions .github/workflows/ci-73.yml

This file was deleted.

4 changes: 2 additions & 2 deletions .github/workflows/ci-74.yml → .github/workflows/ci-81.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Magento 2.4 CI with PHP 7.4
name: Magento 2.4 CI with PHP 8.1

on:
- push
Expand All @@ -11,7 +11,7 @@ jobs:

- name: Launch Magento test environment
env:
PHP: "74"
PHP: "81"
COMPOSE_INTERACTIVE_NO_CLI: "1"
run: make up

Expand Down
9 changes: 1 addition & 8 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
PHP ?= 81
.DEFAULT_GOAL := help
TAG=${git describe --tags}
VERSIONS := 81 74



## -- Container Launch --

## Launch docker-compose as background daemon
.PHONY: up
up: build init fix-session-expire
up: build init


.PHONY: build
Expand All @@ -24,11 +21,7 @@ down:
## Initialise repository - run install-magento
.PHONY: init
init:
ifeq ($(filter $(PHP),$(VERSIONS)),)
docker-compose exec -T web dockerize -wait tcp://db:3306 -timeout 60m /usr/local/bin/install-magento
else
docker-compose exec -T web dockerize -wait tcp://db:3306 -wait tcp://elasticsearch:9200 -timeout 60m /usr/local/bin/install-magento
endif

## -- Development Methods --

Expand Down
7 changes: 6 additions & 1 deletion docker/install-magento
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,12 @@ echo 'Running magento setup:install'
--admin-lastname=$MAGENTO_ADMIN_LASTNAME \
--admin-email=$MAGENTO_ADMIN_EMAIL \
--admin-user=$MAGENTO_ADMIN_USERNAME \
--admin-password=$MAGENTO_ADMIN_PASSWORD
--admin-password=$MAGENTO_ADMIN_PASSWORD \
--search-engine='elasticsearch7' \
--elasticsearch-host='elasticsearch' \
--elasticsearch-port='9200' \
--elasticsearch-enable-auth='0' \
--elasticsearch-timeout='60'
echo 'Enabled Ideal Postcodes extension'
/var/www/html/bin/magento module:enable Idealpostcodes_Ukaddresssearch
Expand Down
4 changes: 1 addition & 3 deletions test/e2e/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"compilerOptions": {
"strict": true,
"baseUrl": "../../node_modules",
"target": "es5",
"lib": ["ES2015", "es5", "dom"],
"lib": ["es5", "dom"],
"types": ["cypress"]
},
"include": ["**/*.ts"]
Expand Down
4 changes: 1 addition & 3 deletions test/snapshot/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{
"compilerOptions": {
"strict": true,
"baseUrl": "../../node_modules",
"target": "es5",
"lib": ["ES2015", "es5", "dom"],
"lib": ["es5", "dom"],
"types": ["cypress"]
},
"include": ["**/*.ts"]
Expand Down

0 comments on commit 30684f6

Please sign in to comment.