Precompute extrapolate #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up viscosity operators in planet tests which were incorrectly coded, and/or behaving incorrectly In particular: planetMigration2D was setting alpha=1e-3, but computation was actually performed with alpha=0. For this reason, the values for this test have been recomputed.
ensure that viscosityStatus is in sync with viscosity object. See merge request discs/idefix!314
field included (and no reconstruction)
emf boundary exchange routines are not needed anymore (because ghost zones are fully exchanged) Add back BX1s... fields in dump files even when we're using vector potential, so that the code can be restarted without vector potentials
(which are not needed anymore in principle)
RFC: deduplicate ouptut.CheckForWrites for initial conditions See merge request discs/idefix!315
Add documentation for git LFS See merge request discs/idefix!318
RFC: split Vtk class into a base and a concrete class See merge request discs/idefix!316
* Braginskii thermal conduction and diffusivity in every dimensions suitable for Idefix v2.0 * braginskii doc * Braginskii doc done * [pre-commit.ci lite] apply automatic fixes --------- Co-authored-by: Geoffroy Lesur <geoffroy.lesur@univ-grenoble-alpes.fr> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
…ing at restart (#192) * ENH: add CLI flag to force calling Setup::InitFlow ahead of dump reading at restart * Update commandline.rst --------- Co-authored-by: Geoffroy Lesur <geoffroy.lesur@univ-grenoble-alpes.fr>
* ENH: define reusable macros for runtime checks * DOC: add documentation for RUNTIME_CHECK macros
* introduce pre-computation of self-gravity Laplacian operator * make the iterative solver deriving from a Laplacian functor * dust mass also contributes to the self-gravitating field
…n grids (#196) * check whether the grid is regular or not * slopelimiter construction now pushed during initialisation to allow the computation of plm coefficients * Add PLM reconstruction coefficient in non-cartesian grids * refactor slope limiters * add Paul Segretain's fix to curvature term in spherical coordinates (no motion in constant pressure setups) * fix axis flux on which we had a small (but measurable) leek of conserved quantities when in perfect equilibrium fix tolerance in planet planet case * update reference for CI/CD
add changelog fix test suite for -noplot
Co-authored-by: Clément Robert <cr52@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to pre-compute the intracell reconstruction of primitive variables before running the Riemann solvers, which is probably more efficient on some architectures (but not on others, as the Nvidia Hackathon demonstrated). Eventually, this PR will automatically choose between on-the-fly extrapolation to faces in the Riemann solver Kernel, or pre-compute, depending on the target architecture.