DEP: bump kokkos (4.1.00->4.2.00) #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it is now enabled by default in Kokkos 4.2 kokkos/kokkos@ac23f36
|
Note for the future, Kokkos 4.2 is now enabling asynchronous Cuda Malloc by default. This can be a problem for old UCX being used in MPI libraries (in particular on our test machine). Hence, we now disable explicitely this option in the test suite. However, I'd prefer not to disable this by default for production runs as it leads to performance improvement. I've added an item in the FAQ so that users see where the problem is if they run into this bug. |
glesur
added a commit
that referenced
this pull request
Mar 22, 2024
* DEP: bump kokkos (4.1.00->4.2.00) * force disable Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC in tests as it is now enabled by default in Kokkos 4.2 kokkos/kokkos@ac23f36 --------- Co-authored-by: Clément Robert <cr52@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identitcal to #216 , but to v2.1