fix segFault with gridCoarsening+MHD when DIMENSIONS==2 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glesur
added a commit
that referenced
this pull request
Mar 29, 2024
* fix Planet::RegisterInDump (#229) * fix segFault with gridCoarsening+MHD when DIMENSIONS==2 (#230) * Fix parabolic MHD+coarsening (#233) * reconstruct BX2s only on the axis (#234) * fix single precision warnings with hipcc * implement per-fluid flux boundaries, as proposed by @PaulSegretain (#235) * DOC: use --recursive-submodules in place of init followed by update (#237) * warn user in case of possible output overflow for very large domain sizes. * add fences when profiling * detect MPI imbalance * add the possibility to produce dumps on a regular real time basis Co-authored-by: volodia99 <gaylor.wafflard@univ-grenoble-alpes.fr> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
glesur
added a commit
that referenced
this pull request
May 13, 2024
* fix Planet::RegisterInDump (#229) * fix segFault with gridCoarsening+MHD when DIMENSIONS==2 (#230) * add a comment on how to disable OMPiO on openmpi in the documentation * Update faq.rst with known MacOs linker bug * Fix parabolic MHD+coarsening (#233) * adding a new test for grid Coarsening * fix currents used with grid Coarsening * reconstruct BX2s only on the axis (#234) * update version & changelog * dumpimage that can work on distributed data * use correct bound for userdef slices * vtk slice automatically handles all of the variables * fix potential segfault in dumpimage * produce slices when emergency outputs * add compile time info * force disable Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC in tests as it is now enabled by default in Kokkos > 4.1 kokkos/kokkos@ac23f36 * Bump up to Kokkos 4.3.1 --------- Co-authored-by: volodia99 <gaylor.wafflard@univ-grenoble-alpes.fr> Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com> Co-authored-by: Clément Robert <cr52@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #226