Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconstruct BX2s only on the axis #234

Merged
merged 1 commit into from
Mar 15, 2024
Merged

reconstruct BX2s only on the axis #234

merged 1 commit into from
Mar 15, 2024

Conversation

glesur
Copy link
Contributor

@glesur glesur commented Mar 14, 2024

fix a bug that could result in discrepancies @ machine precision when using axis boundary conditions and varying the MPI domain decomposition along X2.

@glesur glesur merged commit 54d305d into v2.0.05 Mar 15, 2024
13 checks passed
glesur added a commit that referenced this pull request Mar 29, 2024
* fix Planet::RegisterInDump (#229)

* fix segFault with gridCoarsening+MHD when DIMENSIONS==2 (#230)

* Fix parabolic MHD+coarsening (#233)

* reconstruct BX2s only on the axis (#234)

* fix single precision warnings with hipcc

* implement per-fluid flux boundaries, as proposed by @PaulSegretain (#235)

* DOC: use --recursive-submodules in place of init followed by update (#237)

* warn user in case of possible output overflow for very large domain sizes.

* add fences when profiling

* detect MPI imbalance 

* add the possibility to produce dumps on a regular real time basis


Co-authored-by: volodia99 <gaylor.wafflard@univ-grenoble-alpes.fr>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
glesur added a commit that referenced this pull request May 13, 2024
* fix Planet::RegisterInDump (#229)

* fix segFault with gridCoarsening+MHD when DIMENSIONS==2 (#230)

* add a comment on how to disable OMPiO on openmpi in the documentation

* Update faq.rst with known MacOs linker bug

* Fix parabolic MHD+coarsening (#233)

* adding a new test for grid Coarsening

* fix currents used with grid Coarsening

* reconstruct BX2s only on the axis (#234)

* update version & changelog

* dumpimage that can work on distributed data

* use correct bound for userdef slices

* vtk slice automatically handles all of the variables

* fix potential segfault in dumpimage

* produce slices when emergency outputs

* add compile time info

* force disable Kokkos_ENABLE_IMPL_CUDA_MALLOC_ASYNC in tests
as it is now enabled by default in Kokkos > 4.1
kokkos/kokkos@ac23f36

* Bump up to Kokkos 4.3.1

---------

Co-authored-by: volodia99 <gaylor.wafflard@univ-grenoble-alpes.fr>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Clément Robert <cr52@protonmail.com>
@glesur glesur deleted the fixAxisReconstruction branch July 9, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant