clarify documentation for reflective boundary conditions #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glesur
added a commit
that referenced
this pull request
Jun 19, 2024
* incorrect max diffusion with resistivity (#244) Fix a bug that could result in too restrictive timesteps when resistivity is enabled fix #242 * fix documentation for reflective boundary conditions (#246) fix #228 * Per proc normalisation (#247) - show performance per sub-domain during integration - add performance measures in documentation - update link to method paper - update acknowledgements * Documentation fixes (#248) * directly ask kokkos for its execution space * remove replace source files, as this doesn't work with header files (.hpp) * add proper readme * clean up hdf5 mess in readme (is already in the full doc) * add Async malloc option to JZ configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #228