highlight errors #124
Merged
highlight errors #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swr1bm86
force-pushed
the
highlight-error
branch
2 times, most recently
from
b7a141b to
22bcc5c
Compare
|
Ooops, it needs a rebase after I merged the first PR |
swr1bm86
force-pushed
the
highlight-error
branch
from
22bcc5c to
dc084bf
Compare
|
@melted done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a successor of #33, since it is no longer active.
in Atom, as far as i know, the only way to draw something on the editor is to use decoration. and i believe it is quite impossible to show red underlines under the part of the code that's wrong, just like in idris-mode or vscode-idris. so a trade-off that highlight the whole line is cool enough i think.
@melted @david-christiansen @archaeron