Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subset worker refactor #287

Merged
merged 28 commits into from
Jan 25, 2024
Merged

Subset worker refactor #287

merged 28 commits into from
Jan 25, 2024

Conversation

MattUnderscoreZhang
Copy link
Contributor

Tested with my processing workflow (framerate resampling, resizing, cropping, cut finding, clipping).
Results are identical to before.

Merge after #275.

MattUnderscoreZhang and others added 24 commits January 18, 2024 10:33
@MattUnderscoreZhang
ClippingSubsampler rewrite and bug fixes
2efa849
@MattUnderscoreZhang
More refactoring of ClippingSubsampler, plus a fix to _get_clip_inter…
a5c9649 
…vals
@MattUnderscoreZhang
Finished refactoring ClippingSubsampler
2cb5854
@MattUnderscoreZhang
Merge branch 'clipping_subsampler_rewrite' into all_fixes
6106f62
@MattUnderscoreZhang
Final code changes
5d03b72
@MattUnderscoreZhang
Added docstrings
47c7d64
@MattUnderscoreZhang
Passed tests and linting
5aa84d4
@MattUnderscoreZhang
Made type annotations consistent with Python 3.8
140e1ab
@MattUnderscoreZhang
More annotation fixes
077ca27
@MattUnderscoreZhang
The Python 3.8 annotation needs a lot of hand-holding, it seems
32fa4ea
@MattUnderscoreZhang
Pylint has to cut it out, I swear to God
5a8957f
@MattUnderscoreZhang
No real change, just relauching unit tests which failed due to connec…
f0f0168 
…tion timeouts
@iejMac
Merge branch 'main' into clipping_subsampler_refactor
f5d7c85
@rom1504
Merge branch 'main' into clipping_subsampler_refactor
388f51a
@MattUnderscoreZhang
Merge remote-tracking branch 'origin/main' into clipping_subsampler_r…
5101379 
…efactor
@MattUnderscoreZhang
Linting issue
1df88dd
@MattUnderscoreZhang
Another linting issue
226fba3
@MattUnderscoreZhang
Separated per-shard code from code that should only be executed once
8ed5074
@MattUnderscoreZhang
Pulled ShardStatus parameters into their own data type
e862eaa
@MattUnderscoreZhang
Cleaned up shard processing error handling
d158106
@MattUnderscoreZhang
Cleaned up code
5cd53a9
@MattUnderscoreZhang
Bug fixes
ffe0e71
@MattUnderscoreZhang
Formatting
2c7daf8
@MattUnderscoreZhang
Fixed linting issues
ac5a35b
@MattUnderscoreZhang MattUnderscoreZhang changed the title Subset worker refactoring Subset worker refactor Jan 24, 2024
@MattUnderscoreZhang MattUnderscoreZhang mentioned this pull request Jan 24, 2024
Merged
@rom1504
Copy link
Collaborator

rom1504 commented Jan 24, 2024

I merged #275 ; can you rebase here ?

@MattUnderscoreZhang
Copy link
Contributor Author

Ok done

@iejMac
Copy link
Owner

iejMac commented Jan 24, 2024

looks good on first glance

@MattUnderscoreZhang
Copy link
Contributor Author

Can we merge the worker requests?

@rom1504
Copy link
Collaborator

rom1504 commented Jan 25, 2024

What do you mean by "requests" ?

@MattUnderscoreZhang
Copy link
Contributor Author

Pull requests #287 and #288.
This one and the one about the DownloadWorker.

@rom1504 rom1504 merged commit ab510d0 into iejMac:main Jan 25, 2024
2 checks passed
@rom1504
Copy link
Collaborator

rom1504 commented Jan 25, 2024

Lgtm, this is not doing much, just moving the code around, a bit better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattUnderscoreZhang @rom1504 @iejMac