Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify requirements for resolution of inconsistent information (Paul Wouters' IESG review) #62

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

cabo
Copy link
Member

@cabo cabo commented Oct 18, 2023

No description provided.

@cabo cabo requested a review from ryzokuken as a code owner October 18, 2023 17:54
@@ -789,7 +789,8 @@ extensions still to be defined.
Where consistent interpretation between multiple actors is required
for security purposes (e.g., where timestamps are embedded as
parameters in access control information), only such extensions can be
employed that have a defined resolution of such inconsistent data.
employed that have a well-understood and shared resolution of such

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: s/that/as/.

That's "only such [whatever] as have [what's needed]"; contrast with "you can use [a thing] that has [what's needed], but not one that lacks it."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't feel too strongly about this either way, but that feels better here.

Perhaps s/that/which ("...only such extensions can be employed which have a...")

Copy link
Member Author

@cabo cabo Oct 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is a defining relative clause (the sentence is nonsensical without it), so it must be "that".
I'd like to stick with relatively simple English, so I propose changing the first "such" into "those".

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Well, at this point, I'd s/that/which/ but it'll do.)

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those does read better here

@ryzokuken ryzokuken merged commit 4c44aa4 into main Oct 19, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants