Skip to content

Commit

Permalink
ipc4: helper: fix stream params frame format update
Browse files Browse the repository at this point in the history
When making assignment from ipc4_base_module_cfg, received in
Init Instance IPC to sof_ipc_stream_params, valid_bit_depth is used
to set frame_fmt instead of container size. It is then applied to
buffer format in params/prepare stage. Thus, leads to inconsistancy
between buffer format and actual audio stream.

Signed-off-by: Ievgen Ganakov <ievgen.ganakov@intel.com>
  • Loading branch information
iganakov committed Oct 31, 2024
1 parent 2f4efa5 commit 7b91ffc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/ipc/ipc4/helper.c
Original file line number Diff line number Diff line change
Expand Up @@ -1112,7 +1112,7 @@ void ipc4_base_module_cfg_to_stream_params(const struct ipc4_base_module_cfg *ba
base_cfg->audio_fmt.valid_bit_depth,
&frame_fmt, &valid_fmt,
base_cfg->audio_fmt.s_type);
params->frame_fmt = valid_fmt;
params->frame_fmt = frame_fmt;

for (i = 0; i < SOF_IPC_MAX_CHANNELS; i++)
params->chmap[i] = (base_cfg->audio_fmt.ch_map >> i * 4) & 0xf;
Expand Down

0 comments on commit 7b91ffc

Please sign in to comment.