Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve print in case if consumer is not initialized #1394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hubcio
Copy link
Collaborator

@hubcio hubcio commented Dec 20, 2024

No description provided.

Copy link
Collaborator

@spetz spetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add the comments on both build() methods for IggyConsumer and IggyProducer that the init() should be invoked?

/// Builds the consumer. Invoke the `init()` method before consuming the messages.
/// Builds the producer. Invoke the `init()` method before producing the messages.

Also, update the SDK version :)

@coveralls
Copy link
Collaborator

coveralls commented Dec 20, 2024

Pull Request Test Coverage Report for Build 12432685816

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 75.293%

Changes Missing Coverage Covered Lines Changed/Added Lines %
sdk/src/clients/consumer.rs 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
server/src/streaming/systems/personal_access_tokens.rs 1 85.45%
Totals Coverage Status
Change from base Build 12329818473: -0.004%
Covered Lines: 23231
Relevant Lines: 30854

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants