Add function to count and find problems with missing tests #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test.js
Outdated
| return problems; | ||
| }; | ||
|
|
||
| const test_all = async function () { |
There was a problem hiding this comment.
Could you rename the following functions?
test_all->runAllTestssolve->solveProblem
Also, let's use camelCase everywhere. I noticed we have a mix. A linter rule could solve this too (not need to do it here).
There was a problem hiding this comment.
updated all variables and functions in this file to be camelCase
I also added the eslint rule to make it visible and noticed there are a lot of issues
I can create another PR to solve all of those linter issues
There was a problem hiding this comment.
Love it! that'd be amazing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was added
An output to the console when you run all the tests so you can see how many problems are there and if there is any missing Test
Thanks to this I figured out that 2 of the test files had wrong naming
example output:
Checklist before requesting a review
npx eslint LeetcodeProblems LeetcodeProblemsTests) and unit tests (node Test.js) and they pass. More info.Check the guide and this PR example.