Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexographically smallest after a swap #99

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

meetmukul1993
Copy link
Contributor

@meetmukul1993 meetmukul1993 commented Oct 17, 2024

Title of the problem

3216. Lexicographically Smallest String After a Swap

Checklist before requesting a review

  • I have checked the guide for contributions.
  • I have added the description at the top of the solution file.
  • I have added a test file for the problem.
  • I have added an entry to the README file with a link to the new file.
  • I have run linter (npx eslint LeetcodeProblems LeetcodeProblemsTests) and unit tests (node Test.js) and they pass. More info.

Check the guide and this PR example.

Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the linter issues by running npx eslint LeetcodeProblems LeetcodeProblemsTests

@meetmukul1993
Copy link
Contributor Author

@ignacio-chiazzo updated the PR, can u please have a look again. Thanks

Copy link
Owner

@ignacio-chiazzo ignacio-chiazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@meetmukul1993
Copy link
Contributor Author

@ignacio-chiazzo Seems like the lint check runs after a maintainer approves it, earlier it failed, have updated the code again. can u please approve the lint execution

@ignacio-chiazzo ignacio-chiazzo merged commit 03b48f6 into ignacio-chiazzo:master Oct 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants