Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger context #580

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Mar 21, 2024

This PR contains two related commits:

  1. Introduction of a static 'context' in SmackDebugger, which is a simple static map.
  2. Modification of the SINT framework to store the test that's currently being executed in this new context.

This mechanism allows SmackDebuggers to act in a way specific to the test that is being executed. An immediate use for this is having a log-generating debugger that writes XMPP traffic to a different file for each test.

Copy link
Member

@Flowdalic Flowdalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think there is no need to modify anything outside of smack-integration-test for this approach, therefore we should not touch code, for example, in smack-core.

@Flowdalic Flowdalic added this pull request to the merge queue Apr 3, 2024
Merged via the queue into igniterealtime:master with commit 7139a43 Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants