Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[muc] Invoke ParticipantStatusListener after revokation of membership #609

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Jul 13, 2024

When an occupant gets its membership revoked in an members-only room, the appropriate method of registered ParticipantStatusListeners should be invoked.

@guusdk guusdk requested a review from Flowdalic July 13, 2024 13:01
Copy link
Member

@Flowdalic Flowdalic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash

When an occupant gets its membership revoked in an members-only room, the appropriate method of registered ParticipantStatusListeners should be invoked.
@guusdk guusdk force-pushed the MUC_revoke-membership-in-membersonly-room branch from 6bdce7e to f0b9955 Compare July 14, 2024 08:19
@guusdk
Copy link
Member Author

guusdk commented Jul 14, 2024

Squashed - any reason why you choose not to do that through GitHub's UI, by the way?

@Flowdalic
Copy link
Member

Simply to encourage (and teach) best-practices.

@Flowdalic Flowdalic added this pull request to the merge queue Jul 14, 2024
Merged via the queue into igniterealtime:master with commit 2019e0d Jul 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants