Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing commit to update #173

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Add missing commit to update #173

merged 1 commit into from
Oct 20, 2024

Conversation

feluelle
Copy link
Contributor

Description

fixes: #168

Changes

Add the option to commit the update when return_columns or return_as_model is used.

Tests

I have added a test that manually rolls back the current transaction to see if the record was updated and committed.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added necessary documentation (if appropriate).
  • I have added tests that cover my changes (if applicable).
  • All new and existing tests passed.

@feluelle
Copy link
Contributor Author

@igorbenav PTAL

@igorbenav
Copy link
Owner

Nice and simple!

@igorbenav igorbenav merged commit f3017e9 into igorbenav:main Oct 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbenav igorbenav igorbenav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

commit=True have no effect when return_as_model==True
2 participants
@feluelle @igorbenav