Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit option to upsert_multi #174

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Add commit option to upsert_multi #174

merged 2 commits into from
Oct 20, 2024

Conversation

feluelle
Copy link
Contributor

Description

fixes: #170

Changes

Add a commit option to upsert_multi.

Tests

I have added an assertion to check whether we are still in a transaction after calling upsert_multi with commit=True.

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added necessary documentation (if appropriate).
  • I have added tests that cover my changes (if applicable).
  • All new and existing tests passed.

@feluelle
Copy link
Contributor Author

@igorbenav PTAL

igorbenav
igorbenav approved these changes Oct 20, 2024
View reviewed changes
Copy link
Owner

@igorbenav igorbenav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@igorbenav igorbenav merged commit 9ae2402 into igorbenav:main Oct 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbenav igorbenav igorbenav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upsert_multi doesn't commit
2 participants
@feluelle @igorbenav