🐛Potential fix for resizing artifacts generated by wrong image size r…

…eporting
igorkulman · Nov 7, 2022 · 63dd5d6 · 63dd5d6
1 parent 0e84be6
commit 63dd5d6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/Sources/ChangeMenuBarColor/Commands/Abstract/Command.swift b/Sources/ChangeMenuBarColor/Commands/Abstract/Command.swift
@@ -57,6 +57,7 @@ class Command {
             return nil
         }
 
+        wallpaper.adjustSize()
         Log.debug("Using currently set macOS wallpaper \(path)")
 
         return wallpaper

diff --git a/Sources/ChangeMenuBarColor/Extensions/NSImage+Extensions.swift b/Sources/ChangeMenuBarColor/Extensions/NSImage+Extensions.swift
@@ -110,4 +110,13 @@ extension NSImage {
         // Return nil in case anything fails.
         return nil
     }
+
+    // Images loaded from file sometimes do not report the size correctly, see https://stackoverflow.com/questions/9264051/nsimage-size-not-real-size-with-some-pictures
+    // This can lead to artifcats produces bby resizing operations
+    func adjustSize() {
+        // use the biggest sizes from all the representations https://stackoverflow.com/a/38523158/581164
+        size = representations.reduce(size) { size, representation in
+            return CGSize(width: max(size.width, CGFloat(representation.pixelsWide)), height: max(size.height, CGFloat(representation.pixelsHigh)))
+        }
+    }
 }