Fix dialog InvalidOperationException #434
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close #433. I have changed the response handler from
SetResult
toTrySetResult
to make it safe from the task already completed exception.However, a better fix might be to not let the response handler executes the second time by destroying the
VisibleDialog
component when the player responds or disconnects. There are two related callbacks:OnPlayerDisconnect
andOnPlayerDialogResponse
. But I'm not sure about the execution order of these two callbacks.