reduce padding on LG members/subgroups when none have been added #8061
Conversation
| @@ -2,4 +2,8 @@ | |||
|
|
|||
| .list { | |||
| @include m.main-list-box-table; | |||
|
|
|||
| &.empty { | |||
There was a problem hiding this comment.
You put this in the right place to work, but this style is coming from the wrong file.
It's outside the scope of this PR but this programs/list.scss style should be scoped down to only target the program list and not every .list in the application (everything should be under a .programs-list{ class). Can you make that change here or circle back and make a PR just to do that and then re-do the style in this one? It will also require creating a component style for the learner group list (and possibly other lists which are also accidentally replying on this style).
There was a problem hiding this comment.
Let's chat about this at our next meeting.
michaelchadwick
force-pushed
the
frontend-5633-lg-member_subs-style-remove-padding
branch
from
667f037
to
9c77536
Compare
|
@jrjohnson Hoo boy. Trying fix the change requested led me down a rabbit hole of components and styles and mixins. I think I was able to put on the brakes and just fix the things requested, but I may have threw in something that was needed, even if a bit out of scope for this task. The real fix would take much longer and will have to wait. |
michaelchadwick
deleted the
frontend-5633-lg-member_subs-style-remove-padding
branch
Fixes ilios/ilios#5633