Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show tooltip on top of bar chart #1472

Closed
wants to merge 2 commits into from
Closed

Show tooltip on top of bar chart #1472

wants to merge 2 commits into from

Conversation

itome
Copy link

@itome itome commented Nov 1, 2023

Show tooltip on top of bar chart.
Related issue: #1157

@@ -761,6 +763,8 @@ class BarTouchTooltipData with EquatableMixin {
/// The tooltip border color.
final BorderSide tooltipBorder;

final bool showOnTopOfTheChartBoxArea;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add it in the props section

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.52%. Comparing base (79e6ec7) to head (532847f).
Report is 143 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/chart/bar_chart/bar_chart_painter.dart 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1472      +/-   ##
==========================================
- Coverage   86.54%   86.52%   -0.03%     
==========================================
  Files          45       45              
  Lines        2996     2998       +2     
==========================================
+ Hits         2593     2594       +1     
- Misses        403      404       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imaNNeo
Copy link
Owner

imaNNeo commented Nov 5, 2023

Please read the sontributing guideline carefully,

  • You need to update the docs in bar_chart.md file,
  • You need to write a changelog for it

@imaNNeo
Copy link
Owner

imaNNeo commented Oct 20, 2024

Closing, because it had no activity for a while

@imaNNeo imaNNeo closed this Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants