-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix padding and margin for LineLabels and Tooltips #824 #1587
base: main
Are you sure you want to change the base?
Fix padding and margin for LineLabels and Tooltips #824 #1587
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1587 +/- ##
=======================================
Coverage 87.52% 87.53%
=======================================
Files 45 45
Lines 3078 3072 -6
=======================================
- Hits 2694 2689 -5
+ Misses 384 383 -1 ☔ View full report in Codecov by Sentry. |
What about these changes? There are no more margin parameters, everything is done by vertical and horizontal offsets. I had to generate mockito files again, so I could write more tests, but I have no idea why it bumped the Mockito version on the comments.
|
HI, can you please resolve the conflicts? |
437af1f
to
d1ade1b
Compare
There were many conflicts, but hopefully everything is okay now. :) Not sure about the changelog format though. |
3ba03f4
to
7334849
Compare
Resolved conflicts again. |
Everything seems good to me. |
7334849
to
6303a49
Compare
Can you please rebase again? |
0e8b9ad
to
1eaf49c
Compare
Changelog:
/// Migration guide:
/// Old way:
BarTouchTooltipData(
tooltipMargin: -10,
)
/// New way:
BarTouchTooltipData(
tooltipVerticalOffset: -10, // same effect as old tooltipMargin
tooltipPadding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8), // Adds padding to tooltip
) /// Migration guide:
/// Old way:
ScatterTooltipItem(
bottomMargin: 10,
)
/// New way:
ScatterTouchTooltipData(
tooltipVerticalOffset: 10, // same effect as old tooltipMargin
tooltipPadding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8), // Adds padding to tooltip
) |
@imaNNeo Is this feature still relevant? Should I continue updating/merging or should I focus on other features? |
I wanted to make a PR to check with you @imaNNeo that, this PR is going on the right direction. I still need to make more testing, so a draftish PR.
This PR is for #824 and there were also discussion about adding padding/margin for the tooltips as well.