Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pr 1739/fl scale data #1810

Open
wants to merge 89 commits into
base: main
Choose a base branch
from
Open

Pr 1739/fl scale data #1810

wants to merge 89 commits into from

Conversation

imaNNeo
Copy link
Owner

@imaNNeo imaNNeo commented Dec 19, 2024

No description provided.

@Peetee06
feat: Add Chart zoom and pan (WIP)
5263916
@Peetee06
feat: Allow zooming and panning freely for line chart
4f908b3
@Peetee06
fix: Scaling factor
9ad2942
@Peetee06
fix: Scaling in, translating to maxX/maxY and scaling out now keeps t…
939efc9 
…he translated/scaled values inside min/max bounds
@Peetee06
ref: Use Matrix3 for transformations
a3d5fbe
@Peetee06
feat: Get size from LineChart renderer
900ea0b
@Peetee06
ref: Improve code style
98293fb
@Peetee06
feat: Improve scaling via mouse wheel
1c9a9c1
@Peetee06
ref: Use LayoutBuilder to get size for chart leaf
be1db36
@Peetee06
feat: Allow scaling line chart
0430b78
@Peetee06
feat: Allow panning via trackpad
f9c83fe
@Peetee06
feat: Add panning and zooming for touch gestures
476f9f5
@Peetee06
feat: Add double tap gesture recognizer to render base chart
e432233
@Peetee06
test: Remove unused tests
d808d49
@Peetee06
revert: Move vector_math dependency back to dev dependencies
72f609d
@Peetee06
ref: Move scaling/panning logic to new InteractiveLineChart widget
581f0b8
@Peetee06
fix: Update bounds when widget is updated
a9661bb
@Peetee06
fix: Handle NaN bound values
360bd3c
@Peetee06
ref: Add BaseInteractiveChart and BaseInteractiveChartState
0e5e3e1
@Peetee06
ref: Use BaseInteractiveChartState in InteractiveLineChart
ee18901
@Peetee06
feat: Add InteractiveScatterChart
3032631
@Peetee06
feat: Add FlTapEvent
4127bb9
@Peetee06
fix: Use FlTapEvent for scatter chart sample
1f80c0f
@Peetee06
fix: TypeError when using touchCallbacks of InteractiveCharts
0ddfd24
@Peetee06
feat: Add interactive bar chart
8e51349
@Peetee06
revert: last 26 commits
4493854
@Peetee06
feat: Allow zooming and panning line chart (axis titles WIP)
da09ef4
@Peetee06
fix: Import of custom interactive viewer
30aa5c2
@Peetee06
feat: Add scaling/panning to titles
7376ef0
@Peetee06
feat: Add parameters to control LineChart scale behavior
2ffe36c
Peetee06 and others added 29 commits December 18, 2024 20:46
@Peetee06
test: Add tests for chart renderers
5133521
@Peetee06
fix: Tests for Flutter v3.27.0
8accf95
@Peetee06
ref: Create and reuse clipPaint property on painters
9ed89a9
@Peetee06
ref: Use clipPaint in axis chart painter as well
4657b0a
@Peetee06
fix: Inflate chart rect for titles to avoid clipping
adb756f
@Peetee06
feat: Allow passing transformation controller to control chart transf…
760fd60 
…ormations
@Peetee06
fix: Keep transformation controller if both old and new widget contro…
a0c17c0 
…ller is null
@Peetee06
feat: Add minScale and transformation controller param to bar, line a…
a73d759 
…nd scatter chart
@Peetee06
test: Check that transformation controller is passed from axis chart …
4a4c96c 
…scaffold widget to interactive viewer
@Peetee06
test: Add tests to check if chart rect is set to 0 when scaling goes …
62ccb20 
…to 1.0
@Peetee06
ref: Ignore custom interactive viewer in coverage
aabf7e6
@Peetee06
ref: Use reuse Paint instance for clipping in bar chart painter
973413d
@Peetee06
ref: Use reuse Paint instance for clipping in line chart painter
4127efc
@Peetee06
ref: Use reuse Paint instance for clipping in scatter chart painter
97e90d7
@Peetee06
test: Remove done todos
3f293f4
@Peetee06
test: Add tests for bar chart painter
4e9bd6c
@Peetee06
test: Add test for restoring canvas before and clipping again after d…
d449974 
…rawing extra lines
@Peetee06
test: Add line chart painter test for minY == maxY
985513d
@imaNNeo @Peetee06
Add Bitcoin price history as a line chart sample
1f0a842
@imaNNeo @Peetee06
Add the zoom/scale feature in the line_chart_sample12
b371420
@imaNNeo @Peetee06
Add the transformation controller buttons in the line_chart_sample12
aaf76ff
@imaNNeo @Peetee06
Add the url in the btc_last_year_price.json
28632b7
@Peetee06
fix: Do not dispose external transformation controller
8f501e8
@Peetee06
ref: Rename bounding box to chartVirtualRect
ec27e5c
@Peetee06
ref: Rename ScaleAxis to FlScaleAxis
218282d
@Peetee06
ref: Rename ScaleAxis to FlScaleAxis
d774de3
@Peetee06
test: Add test for skipping drawing tooltip when outside of canvas
2af2607
@Peetee06
test: Add tests for drawTouchTooltip to take dot height into account
9966906
@imaNNeo
Add FlScaleData to move the scale/zoom related fields into it
17e7b74
@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 99.66102% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.02%. Comparing base (ce9e849) to head (17e7b74).

Files with missing lines Patch % Lines
lib/src/chart/line_chart/line_chart_painter.dart 97.14% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1810      +/-   ##
==========================================
+ Coverage   89.69%   93.02%   +3.33%     
==========================================
  Files          44       44              
  Lines        3017     3228     +211     
==========================================
+ Hits         2706     3003     +297     
+ Misses        311      225      -86
Flag Coverage Δ
flutter 93.02% <99.66%> (+3.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imaNNeo @Peetee06