Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow locking scale/translation state #1819

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Peetee06
Copy link
Contributor

@Peetee06 Peetee06 commented Dec 20, 2024

Allows to disable panning and scaling.

When disabled users cannot scale/pan the chart. Transforming the chart via a TransformationController is still possible in this case.

Solves #1818

Demo

Simulator.Screen.Recording.-.iPhone.16.-.2024-12-20.at.16.57.27.mp4

@Peetee06 Peetee06 marked this pull request as draft December 20, 2024 15:22
@Peetee06 Peetee06 force-pushed the feat/allow-locking-scale-pan branch from 52667ad to 8dc8ce0 Compare December 20, 2024 15:59
@Peetee06 Peetee06 marked this pull request as ready for review December 20, 2024 16:05
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (5707210) to head (67132f3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1819   +/-   ##
=======================================
  Coverage   93.19%   93.20%           
=======================================
  Files          45       45           
  Lines        3234     3236    +2     
=======================================
+ Hits         3014     3016    +2     
  Misses        220      220           
Flag Coverage Δ
flutter 93.20% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant