Make avif-native 1.70-compatible #2382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `use std::mem::size_of` - Remove `pub` visibility where unnecessary
|
CI error seems unrelated. |
fintelia
approved these changes
Nov 18, 2024
|
Thanks for the quick action! Do you know when this will be included in a release? |
|
We don't have a specific release schedule. Mostly just try to make a release when a bunch of changes have landed or when someone asks for one. Can try to get one out soon! |
|
I see. Would be nice to have soon, but not critical. Thanks again 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo +1.70 build --no-default-features -F avif-nativedoesn't build (0.25.5). The fixes for this are trivial and only language-related, so I hope these can be included so we don't have to bump the MSRV to1.80when using avif-native.use std::mem::size_ofpubvisibility where unnecessaryNote: Real MSRV could be lower than 1.70, haven't tested <1.70