Fixed test build

imperugo · Dec 23, 2023 · e08c012 · e08c012
1 parent 2197d44
commit e08c012
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 25 deletions.
diff --git a/.github/workflows/dotnetcore.yml b/.github/workflows/dotnetcore.yml
@@ -58,12 +58,6 @@ jobs:
  env:
  REDIS_HOST: localhost
 
- - name: Run netcoreapp2.1 Tests
- run: dotnet test -f netcoreapp2.1 --verbosity quiet
- shell: bash
- env:
- REDIS_HOST: localhost
-
  publish:
  needs: runner-job
  name: Publish Nuget Packages

diff --git a/tests/StackExchange.Redis.Extensions.Core.Tests/CacheClientTestBase.cs b/tests/StackExchange.Redis.Extensions.Core.Tests/CacheClientTestBase.cs
@@ -153,11 +153,11 @@ public async Task Add_Value_Type_To_Redis_Database_Async()
  [Fact]
  public async Task Add_Complex_Item_To_Redis_Database_Async()
  {
- var testobject = new TestClass<DateTime>();
+ var testClass = new TestClass<DateTime>();
 
  var added = await Sut
  .GetDefaultDatabase()
- .AddAsync("my Key", testobject)
+ .AddAsync("my Key", testClass)
  ;
 
  var redisValue = await db.StringGetAsync("my Key");
@@ -168,8 +168,8 @@ public async Task Add_Complex_Item_To_Redis_Database_Async()
 
  Assert.True(db.KeyExists("my Key"));
  Assert.NotNull(obj);
- Assert.Equal(testobject.Key, obj.Key);
- Assert.Equal(testobject.Value.ToUniversalTime(), obj.Value.ToUniversalTime());
+ Assert.Equal(testClass.Key, obj.Key);
+ Assert.Equal(testClass.Value.ToUniversalTime(), obj.Value.ToUniversalTime());
  }
 
  [Fact]

diff --git a/...tackExchange.Redis.Extensions.Core.Tests/StackExchange.Redis.Extensions.Core.Tests.csproj b/...tackExchange.Redis.Extensions.Core.Tests/StackExchange.Redis.Extensions.Core.Tests.csproj
@@ -1,31 +1,19 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
  <PropertyGroup>
- <TargetFrameworks>net6.0;net7.0;;net8.0</TargetFrameworks>
- <TargetFrameworks Condition=" '$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::Linux)))' ">net6.0;net7.0;net8.0;</TargetFrameworks>
- <TargetFrameworks Condition=" '$([System.Runtime.InteropServices.RuntimeInformation]::IsOSPlatform($([System.Runtime.InteropServices.OSPlatform]::OSX)))' ">net6.0;net7.0;net8.0;</TargetFrameworks>
+ <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks>
  <IsPackable>false</IsPackable>
  <IsTestProject>true</IsTestProject>
  <GenerateDocumentationFile>false</GenerateDocumentationFile>
  </PropertyGroup>
 
- <ItemGroup Condition=" '$(TargetFramework)' == 'net7.0'">
- <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
- <PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
- <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
- <PrivateAssets>all</PrivateAssets>
- </PackageReference>
- </ItemGroup>
-
- <ItemGroup Condition=" '$(TargetFramework)' == 'net6.0'">
+ <ItemGroup>
  <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
  <PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
  <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
  <PrivateAssets>all</PrivateAssets>
  </PackageReference>
- </ItemGroup>
-
- <ItemGroup>
+
  <PackageReference Include="xunit" Version="2.6.4" />
  <PackageReference Include="xunit.categories" Version="2.0.8" />
  <PackageReference Include="Moq" Version="4.18.4" />