forked from space-wizards/space-station-14
-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thief objectives overhaul #1005
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-14 into thief-overhaul
Darkmajia
requested changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed: i like a lot of the thief objectives, just have a few issues with some of them. i don't particularly like any of the traitor objectives, though
Resources/Locale/en-US/_Impstation/objectives/conditions/steal-target-groups.ftl
Outdated
Show resolved
Hide resolved
Darkmajia
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added A LOT (41!) new possible thief + traitor steal objectives. additionally i made pipi one of the eligible animals for the CMO's pet objective, as she is part of that mob spawn pool.
and i also moved pipi and finfin's sprites to our file structure. and the SVS objectives.
i changed the CMO's over-ear headset objective to instead be a "collect x command headsets" objective, as the CMO already has two high profile theft targets (hypospray + portable crewmon) and there is nothing special about that headset compared to any other command headset. i suspect the upper bound on this may be too high for low-command shifts but this is something playtests will reveal.
i SUSPECT some of these may be too disruptive in practice (AI core, particle accelerator), but i think it is worth playing with
Changelog
🆑