Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmo Prestige Outfits #1025

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SixValentine
Copy link

Changelog

Add: CMO Great Cloak and the CMO's Labcoat - 50hr Prestige items

requirement:
!type:RoleTimeRequirement
role: JobChiefMedicalOfficer
time: 180000 #50 hrs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have a 50 hour prestige loadoutEffectGroup for cmo: you can use VeteranCMO for the loadouts and delete this one since it's essentially a duplicate

- !type:GroupLoadoutEffect
proto: PrestigeCMO

- type: startingGear

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just for visitor roles and other entities that get spawned with clothes, so this isn't required

- !type:GroupLoadoutEffect
proto: PrestigeCMO

- type: startingGear

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto on the visitor roles thing

@@ -59,6 +69,19 @@
equipment:
neck: ClothingNeckMantleCMO

- type: loadout

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move these loadout prototypes to the _Impstation folder?

- type: entity
parent: [ClothingNeckBase, BaseCommandContraband]
id: ClothingNeckCloakCmosgreatcloak
name: chief medical officer's great cloak

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic, but the other greatcoats are one word: i suppose this is another type of Thing, but greatcloak might be more in-line

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pedantic, but the other greatcoats are one word: i suppose this is another type of Thing, but greatcloak might be more in-line

well notably this one is a cloak, not a greatcoat

greatcoat's just an old-fashioned word for a big fucking coat

this thing's a cape....... could call it something else i guess but just noting the difference ya

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a great (adjective) cloak, it's a greatcloak. agreeing w dark that it would feel better if it were one word

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already been changed to one word I agree as well beacuse it matches up with Greycloak as well

@@ -0,0 +1,14 @@
- type: entity
parent: [ClothingOuterStorageBase, AllowSuitStorageClothing, BaseCommandContraband]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the previous parenting comment, but with ClothingOuterCoatLabCmo

parent: [ClothingOuterStorageBase, AllowSuitStorageClothing, BaseCommandContraband]
id: ClothingOuterCoatCMO
name: Chief Medical Officer's Labcoat
description: A Medical Labcoat for the Chief Medical officer. The high collar acts as a splash guard for when a patient's veins are particularly leaky.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

officer should have a capital, and medical labcoat should be lowercase too. other instances of lab coats have it as two separate words as well

@@ -80,3 +80,14 @@
sprite: _Impstation/Clothing/Neck/Cloaks/hosgreatcoat.rsi
- type: StealTarget
stealGroup: HeadCloak

- type: entity
parent: [ClothingNeckBase, BaseCommandContraband]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you parent this to just ClothingCloakCmo (so, parent: ClothingCloakCmo with no need for square brackets) then you don't need to copy components like the StealTarget and it'll automatically get adjusted if the base item ever gets anything added to it

- type: Armor
modifiers:
coefficients:
Caustic: 0.75

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for any files that have this "stop sign" at the end of them in github's "Files changed" tab, please leave a blank new line at the end of it. github hates it and it screams and it cries when you dont do this

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repoman jumpscare

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

repoman jumpscare get scared get scared get scared

… for god knows why. If anyone can fix that feel free to I commented it out just so that I could finally be fucking done
@SixValentine SixValentine marked this pull request as ready for review December 14, 2024 18:21
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove all of repoman.rsi, sorry six

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not actually know how

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants