Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up RemovePasswordIfEmptyMiddleware #612

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Clean up RemovePasswordIfEmptyMiddleware #612

merged 1 commit into from
Nov 8, 2024

Conversation

pixeldesu
Copy link
Member

Fixes in2code-pro/femanager#36

  • Skips the entire logic if we're not on a tx_femanager_edit action
  • Removes the second fetch of the request body from the request object, reutilizing the initally acquired request body for the outside conditional check

@sbusemann sbusemann added this to the 8.2.1 milestone Nov 8, 2024
@sbusemann sbusemann merged commit e28ff04 into main Nov 8, 2024
10 of 13 checks passed
@sbusemann sbusemann deleted the feature/password-middleware-cleanup branch November 8, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbusemann sbusemann Awaiting requested review from sbusemann

Assignees
No one assigned
Labels
status: resolved
Projects
None yet
Milestone
8.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@pixeldesu @sbusemann